-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Docker image for testing on GPUs #12368
Conversation
The CI job hasn't been finished yet, but it seems alright so far. https://dev.azure.com/PytorchLightning/pytorch-lightning/_build/results?buildId=61478&view=logs&j=3afc50db-e620-5b81-6016-870a6976ad29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akihironitta!
also curious how we uploaded corrupted image as each image at the end shall have its own testing... |
@Borda The corrupted image doesn't raise any error as seen in this "successful run" build-CUDA (3.7, 1.8) for instance. Building itself was successful, but since there's no sanity check ( |
Thank you so much @akihironitta |
What does this PR do?
Temporary fix for #12314. For unblocking other PRs, tries to pin the most recent docker image in which the tests were running successfully.
Specifically, the one used in https://dev.azure.com/PytorchLightning/pytorch-lightning/_build/results?buildId=61012&view=logs&j=3afc50db-e620-5b81-6016-870a6976ad29&t=bd0a18db-4e66-438b-93e9-00d86028355e.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @tchaton @rohitgr7 @akihironitta @carmocca @Borda