Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CircleCI jobs in seperate workflows to enable rerunning individually #12449

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Mar 25, 2022

What does this PR do?

Enables individually rerunning the two circleci jobs, build-Docs and TPU-tests by dividing the workflow into two for each job.

Just trying... not 100% sure if it works. It seems working correctly :)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [RFC] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

For reference: https://circleci.com/docs/2.0/configuration-reference/#workflows

cc @Borda @carmocca @akihironitta

@akihironitta akihironitta mentioned this pull request Mar 25, 2022
6 tasks
@akihironitta akihironitta added this to the 1.6 milestone Mar 25, 2022
@akihironitta akihironitta added the ci Continuous Integration label Mar 25, 2022
@akihironitta akihironitta enabled auto-merge (squash) March 25, 2022 07:15
@akihironitta
Copy link
Contributor Author

@Borda I think I have to ask someone with a higher privilege to change the setting in this repo. Could you update it after (or before?) this PR lands if you can?

Screen Shot 2022-03-25 at 17 30 22

@Borda
Copy link
Member

Borda commented Mar 25, 2022

I think I have to ask someone with a higher privilege to change the setting in this repo. Could you update it after (or before?) this PR lands if you can?

yes, need to ping @lexierule

.circleci/config.yml Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 25, 2022
@mergify mergify bot requested a review from a team March 25, 2022 10:57
@awaelchli
Copy link
Contributor

something is blocked :(
image

@Borda
Copy link
Member

Borda commented Mar 27, 2022

something is blocked :( image

yep, we know, need Admin to update the required checks and the rename drops the original and creates two new ones instead... :)

@carmocca
Copy link
Contributor

Let's change that after the release so current PRs don't need to re-run their CI

@akihironitta ping me if I forget!

@carmocca carmocca modified the milestones: 1.6, 1.6.x Mar 28, 2022
@akihironitta akihironitta disabled auto-merge March 29, 2022 11:38
@akihironitta akihironitta marked this pull request as draft March 29, 2022 11:38
@akihironitta akihironitta marked this pull request as ready for review March 30, 2022 06:37
@Borda Borda enabled auto-merge (squash) March 30, 2022 08:09
@akihironitta
Copy link
Contributor Author

Hi @Borda @carmocca, this is nothing urgent, but could you ping @lexierule to update the setting for required jobs so that we can merge this PR?

@Borda
Copy link
Member

Borda commented Apr 4, 2022

to update the setting for required jobs so that we can merge this PR?

I was checking with her last week, and for some reason, the next CicleCI job is not visible... would need to check again

@lexierule lexierule disabled auto-merge April 4, 2022 13:07
@lexierule lexierule merged commit e48f136 into master Apr 4, 2022
@lexierule lexierule deleted the ci/split-circleci branch April 4, 2022 13:08
@akihironitta
Copy link
Contributor Author

@Borda Any idea why the old one is still required as seen in #12614?

Screen Shot 2022-04-05 at 13 18 51

@Borda
Copy link
Member

Borda commented Apr 5, 2022

Any idea why the old one is still required as seen in #12614?

this was merged, but still, need to sync with @lexierule 🐰

rohitgr7 pushed a commit that referenced this pull request Apr 12, 2022
lexierule pushed a commit that referenced this pull request Apr 13, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants