Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated LayerSummary and ModelSummary #12593

Merged
merged 5 commits into from
Apr 10, 2022
Merged

Remove deprecated LayerSummary and ModelSummary #12593

merged 5 commits into from
Apr 10, 2022

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Apr 3, 2022

What does this PR do?

Part of #12521

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya changed the title remove dep remove LayerSummary and ModelSummary Apr 3, 2022
@mergify mergify bot added the has conflicts label Apr 3, 2022
@mergify mergify bot removed the has conflicts label Apr 3, 2022
@Borda Borda added the deprecation Includes a deprecation label Apr 4, 2022
@akihironitta akihironitta changed the title remove LayerSummary and ModelSummary Remove deprecated LayerSummary and ModelSummary Apr 4, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 4, 2022
@kaushikb11 kaushikb11 added this to the 1.7 milestone Apr 4, 2022
@awaelchli awaelchli enabled auto-merge (squash) April 10, 2022 07:31
@awaelchli awaelchli merged commit 3684282 into Lightning-AI:master Apr 10, 2022
@carmocca carmocca added breaking change Includes a breaking change and removed deprecation Includes a deprecation labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants