Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated pl.callbacks.ProgressBar #12658

Merged
merged 13 commits into from
Apr 11, 2022
Merged

Remove the deprecated pl.callbacks.ProgressBar #12658

merged 13 commits into from
Apr 11, 2022

Conversation

rschireman
Copy link
Contributor

What does this PR do?

Fixes part of #12521 by removing deprecated pytorch lightning.callbacks.progress.progress bar

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

carmocca
carmocca approved these changes Apr 7, 2022
View reviewed changes
tests/deprecated_api/test_remove_1-7.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@carmocca carmocca added breaking change Includes a breaking change progress bar: tqdm labels Apr 7, 2022
@carmocca carmocca added this to the 1.7 milestone Apr 7, 2022
@carmocca carmocca changed the title Remove deprecated pytorch lightning.callbacks.progress.progress bar Remove the deprecated pytorch lightning.callbacks.ProgressBar Apr 7, 2022
@carmocca carmocca changed the title Remove the deprecated pytorch lightning.callbacks.ProgressBar Remove the deprecated pl.callbacks.ProgressBar Apr 7, 2022
Raymond G Schireman and others added 3 commits April 7, 2022 12:03
add Runif back to tests
3235316
Merge branch 'remove-deprecated-pytorch_lightning.callbacks.progress.…
52f4a36 
…ProgressBar' of github.com:rschireman/pytorch-lightning into remove-deprecated-pytorch_lightning.callbacks.progress.ProgressBar
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
19cf567 
for more information, see https://pre-commit.ci
@mergify mergify bot added the has conflicts label Apr 7, 2022
awaelchli
awaelchli approved these changes Apr 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/__init__.py Show resolved Hide resolved
@Borda @awaelchli
Apply suggestions from code review
a914903 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Borda
Borda reviewed Apr 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 9, 2022
@Borda Borda mentioned this pull request Apr 9, 2022
Closed
44 tasks
awaelchli
awaelchli reviewed Apr 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) April 10, 2022 05:28
@rschireman rschireman mentioned this pull request Apr 10, 2022
Merged
6 tasks
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 10, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 11, 2022
@awaelchli awaelchli merged commit 9d343ba into Lightning-AI:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
breaking change Includes a breaking change progress bar: tqdm ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@rschireman @awaelchli @Borda @carmocca @akihironitta