-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix logging config and add profiler test #1267
fix logging config and add profiler test #1267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1267 +/- ##
======================================
Coverage 92% 92%
======================================
Files 61 61
Lines 3153 3154 +1
======================================
+ Hits 2886 2887 +1
Misses 267 267 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it done...
@jeremyjordan what happens right now if i interrupt training for profiling? |
@williamFalcon the profiler summary gets printed (or saved to file) in this is called if:
i believe all of the cases are covered for when we want to log the profiler summary, as |
Before submitting
What does this PR do?
Fixes #1236
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃