Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero division error for empty dataloaders #12885

Merged
merged 11 commits into from
May 3, 2022
Merged

Fix zero division error for empty dataloaders #12885

merged 11 commits into from
May 3, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 26, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #12830

Also if there are insufficient batches when using limi_train_batches=float (for eg, total batches=9 and limit_train_batches=0.1), it is used to silently disable the training. Ideally, it should raise an error just like it does with eval dataloaders.

Also, it is weird that when the input dataloaders have no batches, it just raises a warning and doesn't do anything but for the above case, it raises an exception. IMO we should start raising an exception in this case too?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @justusschock @awaelchli @ninginthecloud @rohitgr7 @Borda

@rohitgr7 rohitgr7 added bug Something isn't working data handling Generic data-related topic labels Apr 26, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone Apr 26, 2022
@rohitgr7 rohitgr7 requested review from krshrimali and otaj April 27, 2022 09:58
@rohitgr7 rohitgr7 marked this pull request as ready for review April 27, 2022 09:58
carmocca
carmocca approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it is weird that when the input dataloaders have no batches, it just raises a warning and doesn't do anything but for the above case, it raises an exception. IMO we should start raising an exception in this case too?

I agree

pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
tests/trainer/connectors/test_data_connector.py Outdated Show resolved Hide resolved
tests/trainer/test_trainer.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Apr 27, 2022
@carmocca carmocca added the breaking change Includes a breaking change label Apr 27, 2022
Borda
Borda approved these changes May 3, 2022
View reviewed changes
pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
@rohitgr7 rohitgr7 enabled auto-merge (squash) May 3, 2022 18:06
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 3, 2022
tchaton
tchaton approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 merged commit 9bfbd9e into master May 3, 2022
@rohitgr7 rohitgr7 deleted the fix/empty_dl branch May 3, 2022 20:40
carmocca added a commit that referenced this pull request May 9, 2022
@rohitgr7 @carmocca
Fix zero division error for empty dataloaders (#12885)
9c27599 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
carmocca added a commit that referenced this pull request May 31, 2022
@rohitgr7 @carmocca
Fix zero division error for empty dataloaders (#12885)
e9f7737 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@rohitgr7 @carmocca @lexierule
Fix zero division error for empty dataloaders (#12885)
05753bd 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@otaj otaj otaj approved these changes

@Borda Borda Borda approved these changes

@krshrimali krshrimali Awaiting requested review from krshrimali

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
breaking change Includes a breaking change bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.

Raise a error [ZeroDivisionError: float division by zero] at trainer/connectors/data_connector.py
5 participants
@rohitgr7 @Borda @otaj @carmocca @tchaton