-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Azure - multiple configs #12984
CI: Azure - multiple configs #12984
Conversation
it is expected to fail the PT1.11 until docker is unpin in #12373 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
This reverts commit fd5237d.
For the note, the current failures are:
These native FSDP failures should be fixed in #12985, so in this PR, we're going to just disable them. |
This reverts commit 3f7df1b.
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
This PR should finally be ready for merge after #12870 lands. |
'PyTorch - LTS': | ||
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.7-torch1.8" | ||
'PyTorch - stable': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we shorten this text?
'PyTorch - LTS': | |
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.7-torch1.8" | |
'PyTorch - stable': | |
'LTS': | |
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.7-torch1.8" | |
'stable': |
* CI: Azure - multiple configs * names * benchmark * Apply suggestions from code review Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* CI: Azure - multiple configs * names * benchmark * Apply suggestions from code review Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* CI: Azure - multiple configs * names * benchmark * Apply suggestions from code review Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
What does this PR do?
Followup #12373
Extend testing configs for GPU also for the latest version
cc: @akihironitta
Closes #12955.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda