-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPU & TPU doesn't support torch.inference_mode #13014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerome <janand@habana.ai>
for more information, see https://pre-commit.ci
Signed-off-by: Jerome <janand@habana.ai>
jerome-habana
requested review from
williamFalcon,
tchaton,
awaelchli,
edenlightning,
Borda,
SeanNaren,
carmocca,
justusschock,
kaushikb11 and
rohitgr7
as code owners
May 9, 2022 04:49
kaushikb11
reviewed
May 9, 2022
kaushikb11
added
priority: 0
High priority task
accelerator: hpu (external)
Habana Processing Unit
bug
Something isn't working
labels
May 9, 2022
kaushikb11
reviewed
May 9, 2022
kaushikb11
approved these changes
May 9, 2022
Borda
approved these changes
May 9, 2022
rohitgr7
reviewed
May 9, 2022
Signed-off-by: Jerome <janand@habana.ai>
rohitgr7
approved these changes
May 9, 2022
Borda
reviewed
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go
kaushikb11
changed the title
HPU doesn't support torch.inference_mode
HPU & TPU doesn't support torch.inference_mode
May 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: hpu (external)
Habana Processing Unit
bug
Something isn't working
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jerome janand@habana.ai
What does this PR do?
#12715 introduced torch.inference_mode without checking all backends. This resulted in the following error on habana backends
"RuntimeError: Cannot set version_counter for inference tensor"
This PR disables inference_mode and uses no_grad mode for eval/predict stages with hpu backend. Once hpu impl adds support for inference_mode, this check will be removed.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃