Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-optimizer tests with hpu #13217

Merged
merged 6 commits into from
Jun 21, 2022

Conversation

jerome-habana
Copy link
Contributor

@jerome-habana jerome-habana commented Jun 3, 2022

Signed-off-by: Jerome janand@habana.ai

What does this PR do?

Enable multiple optimizer support for hpu and add a sample test

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the 1.7 milestone Jun 8, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 8, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) June 13, 2022 05:05
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 15, 2022
auto-merge was automatically disabled June 16, 2022 03:09

Head branch was pushed to by a user without write access

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 16, 2022
jerome-habana and others added 4 commits June 20, 2022 18:17
@kaushikb11 kaushikb11 enabled auto-merge (squash) June 20, 2022 17:18
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 20, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 20, 2022
@kaushikb11 kaushikb11 merged commit cd44512 into Lightning-AI:master Jun 21, 2022
@jerome-habana jerome-habana deleted the hpu_optim branch June 21, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: hpu (external) Habana Processing Unit ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants