Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CLI registries and update documentation #13221

Merged
merged 10 commits into from
Jun 21, 2022
Merged

Deprecate CLI registries and update documentation #13221

merged 10 commits into from
Jun 21, 2022

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Jun 3, 2022

What does this PR do?

Fixes #12961

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

docs/source/cli/lightning_cli_advanced_3.rst Outdated Show resolved Hide resolved
@carmocca carmocca added docs Documentation related deprecation Includes a deprecation lightningcli pl.cli.LightningCLI labels Jun 6, 2022
@carmocca carmocca added this to the 1.7 milestone Jun 6, 2022
@carmocca carmocca added the community This PR is from the community label Jun 6, 2022
@mergify mergify bot removed the has conflicts label Jun 17, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 21, 2022
@carmocca carmocca enabled auto-merge (squash) June 21, 2022 15:09
@carmocca carmocca merged commit 0ae9627 into Lightning-AI:master Jun 21, 2022
@mauvilsa mauvilsa deleted the cli-deprecate-registries branch June 21, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community deprecation Includes a deprecation docs Documentation related lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] Follow-up tasks to #12614
4 participants