-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate CLI registries and update documentation #13221
Merged
carmocca
merged 10 commits into
Lightning-AI:master
from
mauvilsa:cli-deprecate-registries
Jun 21, 2022
Merged
Deprecate CLI registries and update documentation #13221
carmocca
merged 10 commits into
Lightning-AI:master
from
mauvilsa:cli-deprecate-registries
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauvilsa
requested review from
Borda,
tchaton,
SeanNaren,
carmocca,
edenlightning,
awaelchli,
williamFalcon,
justusschock,
kaushikb11 and
rohitgr7
as code owners
June 3, 2022 09:50
carmocca
approved these changes
Jun 6, 2022
carmocca
reviewed
Jun 6, 2022
carmocca
added
docs
Documentation related
deprecation
Includes a deprecation
lightningcli
pl.cli.LightningCLI
labels
Jun 6, 2022
- Added default values to optimizer_class and lr_scheduler_class.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
awaelchli
approved these changes
Jun 21, 2022
Borda
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
This PR is from the community
deprecation
Includes a deprecation
docs
Documentation related
lightningcli
pl.cli.LightningCLI
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12961
Does your PR introduce any breaking changes? If yes, please list them.
NoneBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃