Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DummyLogger can be called with unknown methods #13224

Merged
merged 11 commits into from
Jun 22, 2022
Merged

DummyLogger can be called with unknown methods #13224

merged 11 commits into from
Jun 22, 2022

Conversation

HallerPatrick
Copy link
Contributor

What does this PR do?

This PR overrides the __getattr__ method of the DummyLogger class, such that an unkown method calls due to external
loggers do not cause an AttributeError but return a dummy method and print information about the call to a non-existing method.

Fixes #13203

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

carmocca
carmocca reviewed Jun 6, 2022
View reviewed changes
pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved
tests/loggers/test_logger.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved
@carmocca carmocca self-assigned this Jun 6, 2022
@carmocca carmocca added feature Is an improvement or enhancement logger Related to the Loggers community This PR is from the community labels Jun 6, 2022
@carmocca carmocca added this to the 1.7 milestone Jun 6, 2022
awaelchli
awaelchli reviewed Jun 21, 2022
View reviewed changes
pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jun 21, 2022
awaelchli
awaelchli approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the test needs an update

tests/tests_pytorch/loggers/test_logger.py Outdated Show resolved Hide resolved
rohitgr7
rohitgr7 reviewed Jun 21, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
tests/tests_pytorch/loggers/test_logger.py Outdated Show resolved Hide resolved
src/pytorch_lightning/loggers/logger.py Show resolved Hide resolved
HallerPatrick and others added 2 commits June 22, 2022 12:06
@HallerPatrick @rohitgr7
Update CHANGELOG.md
c8f9c99 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@HallerPatrick @rohitgr7
Update src/pytorch_lightning/trainer/trainer.py
2833cc1 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@rohitgr7 rohitgr7 enabled auto-merge (squash) June 22, 2022 10:41
@mergify mergify bot added the ready PRs ready to be merged label Jun 22, 2022
@rohitgr7 rohitgr7 merged commit 887dc0f into Lightning-AI:master Jun 22, 2022
@HallerPatrick HallerPatrick deleted the dummy_logger_fast_dev_runnable branch June 22, 2022 15:52
@carmocca carmocca removed their assignment Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca left review comments

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@otaj otaj otaj approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
community This PR is from the community feature Is an improvement or enhancement logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.

DummyLogger AttributeError when calling WandbLogger methods with fast_dev_run
5 participants
@HallerPatrick @awaelchli @otaj @carmocca @rohitgr7