Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ClustertEnvironment methods #13458

Merged
merged 7 commits into from
Jul 13, 2022
Merged

Remove deprecated ClustertEnvironment methods #13458

merged 7 commits into from
Jul 13, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 29, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Part of #12521

Does your PR introduce any breaking changes? If yes, please list them.

Yes, these APIs get removed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @ananthsub

@awaelchli awaelchli added this to the pl:1.7 milestone Jun 29, 2022
@awaelchli awaelchli marked this pull request as ready for review June 29, 2022 22:25
@mergify mergify bot added the ready PRs ready to be merged label Jun 30, 2022
@awaelchli awaelchli mentioned this pull request Jul 1, 2022
Closed
@akihironitta akihironitta enabled auto-merge (squash) July 4, 2022 22:31
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 5, 2022
@akihironitta akihironitta mentioned this pull request Jul 6, 2022
Closed
44 tasks
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Jul 9, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 13, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 13, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 13, 2022
@akihironitta akihironitta merged commit daf7cec into master Jul 13, 2022
@akihironitta akihironitta deleted the refactor/remove-old-cluster-env-methods branch July 13, 2022 19:53
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@awaelchli @akihironitta @jerome-habana
Remove deprecated ClustertEnvironment methods (Lightning-AI#13458)
8d8211e 
* Remove deprecated ClustertEnvironment methods

* update changelog

* ignore typing error

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
breaking change Includes a breaking change environment: kubeflow environment: lsf environment: torchelastic environment ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@awaelchli @Borda @carmocca @justusschock @akihironitta @rohitgr7