Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Habana collective comm deprecation #13463

Closed
wants to merge 1 commit into from
Closed

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jun 30, 2022

What does this PR do?

Fixes Habana collective comm deprecation

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @jerome-habana @kaushikb11

@kaushikb11 kaushikb11 added the accelerator: hpu (external) Habana Processing Unit label Jun 30, 2022
@kaushikb11 kaushikb11 self-assigned this Jun 30, 2022
@kaushikb11 kaushikb11 requested a review from justusschock as a code owner June 30, 2022 07:24
@awaelchli awaelchli added this to the pl:1.6.x milestone Jun 30, 2022
@awaelchli awaelchli added the bug Something isn't working label Jun 30, 2022
Copy link
Contributor

@jerome-habana jerome-habana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are already part of #13423

@akihironitta
Copy link
Contributor

Closing in favor of #13423 given that the change is so simple that it can be coupled together there. (Feel free to reopen this if needed!)

@akihironitta akihironitta deleted the fix/hpu_deprecation branch June 30, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: hpu (external) Habana Processing Unit bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants