Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pytorch_lightning.core.decorators.parameter_validation #13514

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Remove deprecated pytorch_lightning.core.decorators.parameter_validation #13514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0423771
Removal of depreciated code from decorators
shantam-8 Jul 3, 2022
946e22f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 3, 2022
56da198
Correction
shantam-8 Jul 3, 2022
6db5271
Update CHANGELOG.md
shantam-8 Jul 3, 2022
db374ab
Removed imports
shantam-8 Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pytorch_lightning/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

### Removed

- Removed deprecated `pytorch_lightning.core.decorators.parameter_validation` from `decorators` ([#13514](https://github.com/Lightning-AI/lightning/pull/13514))


- Removed the deprecated `Logger.close` method ([#13149](https://github.com/PyTorchLightning/pytorch-lightning/pull/13149))


Expand Down
60 changes: 0 additions & 60 deletions src/pytorch_lightning/core/decorators.py
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions tests/tests_pytorch/deprecated_api/test_remove_1-7.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
TorchElasticEnvironment,
)
from pytorch_lightning.strategies import SingleDeviceStrategy
from tests_pytorch.deprecated_api import _soft_unimport_module
from tests_pytorch.plugins.environments.test_lsf_environment import _make_rankfile


Expand Down Expand Up @@ -99,15 +98,6 @@ def on_post_move_to_device(self):
trainer.fit(model)


def test_v1_7_0_deprecate_parameter_validation():

_soft_unimport_module("pytorch_lightning.core.decorators")
akihironitta marked this conversation as resolved.
Show resolved Hide resolved
with pytest.deprecated_call(
match="Using `pytorch_lightning.core.decorators.parameter_validation` is deprecated in v1.5"
):
from pytorch_lightning.core.decorators import parameter_validation # noqa: F401


def test_v1_7_0_deprecated_slurm_job_id():
trainer = Trainer()
with pytest.deprecated_call(match="Method `slurm_job_id` is deprecated in v1.6.0 and will be removed in v1.7.0."):
Expand Down