Skip to content

Fix gatekeeper minimum check #13769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carmocca merged 1 commit into from
Jul 21, 2022
Merged

Fix gatekeeper minimum check #13769

carmocca merged 1 commit into from
Jul 21, 2022

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 20, 2022 •
edited by github-actions bot
Loading

What does this PR do?

The gatekeeper implementation does not correctly check the general minimum value. We need to use the per-group check

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Jul 20, 2022
@carmocca carmocca added this to the pl:1.7 milestone Jul 20, 2022
@carmocca carmocca self-assigned this Jul 20, 2022
@carmocca carmocca enabled auto-merge (squash) July 20, 2022 20:11
@mergify mergify bot added the ready PRs ready to be merged label Jul 21, 2022
@mergify mergify bot requested a review from a team July 21, 2022 07:22
@carmocca carmocca merged commit bc6d735 into master Jul 21, 2022
@carmocca carmocca deleted the ci/gatekeeper-min branch July 21, 2022 13:53
justusschock pushed a commit that referenced this pull request Jul 21, 2022
@carmocca @justusschock
Fix gatekeeper minimum check (#13769)
2181a16
Borda pushed a commit that referenced this pull request Jul 25, 2022
@carmocca @Borda
Fix gatekeeper minimum check (#13769)
d22a25b 
(cherry picked from commit bc6d735)
justusschock added a commit that referenced this pull request Jul 25, 2022
@justusschock @rohitgr7
@pre-commit-ci @Borda @raoakarsha @dependabot @carmocca @manskx @awaelchli @Jungwon-Lee @NathanielDamours @jxtngx @otaj @gautierdag @akihironitta
Merge different gpu backends with accelerator='gpu' (#13642)
2278719 
* Rename GPUAccelerator to CUDAAccelerator

* Add back GPUAccelerator and deprecate it

* Remove temporary registration

* accelerator connector reroute

* accelerator_connector tests

* update enums

* lite support + tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* typo

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* move "gpu" support up before actual accelerator flag checks

* Stupid arguments

* fix tests

* change exception type

* fix registry test

* pre-commit

* CI: debug HPU flow (#13419)

* Update the hpu-tests.yml to pull docker from vault
* fire & sudo
* habana-gaudi-hpus
* Check the driver status on gaudi server (#13718)

Co-authored-by: arao <arao@habana.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Akarsha Rao <94624926+raoakarsha@users.noreply.github.com>

* Update typing-extensions requirement from <4.2.1,>=4.0.0 to >=4.0.0,<4.3.1 in /requirements (#13529)

Update typing-extensions requirement in /requirements

Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version.
- [Release notes](https://github.com/python/typing_extensions/releases)
- [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md)
- [Commits](python/typing_extensions@4.0.0...4.3.0)

---
updated-dependencies:
- dependency-name: typing-extensions
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit suggestions (#13540)

updates:
- [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [FIX] Native FSDP precision + tests (#12985)

* Simplify fetching's loader types (#13111)

* Include app templates to the lightning and app packages (#13731)

* Include app templates to the package

Co-authored-by: mansy <mansy@lightning.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py (#13617)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Fix typos initialize in docs (#13557)


Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Fix main progress bar counter when `val_check_interval=int` and `check_val_every_n_epoch=None` (#12832)

* Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` (#13688)

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` (#13691)

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>

* fix mypy errors for loggers/wandb.py (#13483)


Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

* Fix gatekeeper minimum check (#13769)

* changelog

* changelog

* fix order

* move up again

* add missing test

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: arao <arao@habana.ai>
Co-authored-by: Akarsha Rao <94624926+raoakarsha@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean Naren <sean@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Mansy <ahmed.mansy156@gmail.com>
Co-authored-by: mansy <mansy@lightning.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Lee Jungwon <33821003+BongYang@users.noreply.github.com>
Co-authored-by: Nathaniel D'Amours <88633026+NathanielDamours@users.noreply.github.com>
Co-authored-by: Justin Goheen <26209687+JustinGoheen@users.noreply.github.com>
Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>
Co-authored-by: Gautier Dagan <s2234411@ed.ac.uk>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
lexierule pushed a commit that referenced this pull request Jul 25, 2022
@carmocca @lexierule
Fix gatekeeper minimum check (#13769)
f08f1e1 
(cherry picked from commit bc6d735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

+2 more reviewers

@akihironitta akihironitta akihironitta approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.7

Development

Successfully merging this pull request may close these issues.

4 participants

@carmocca @Borda @akihironitta @kaushikb11