Skip to content

pkg: parse local versions #13933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lexierule merged 6 commits into from
Aug 1, 2022
Merged

pkg: parse local versions #13933

lexierule merged 6 commits into from
Aug 1, 2022

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jul 29, 2022 •
edited
Loading

What does this PR do?

this actually set some hard min version and then defines the rest as bug-fix free, for example:

pytorch_lightning==1.7.*,>=1.6.5
lightning_app==0.6.*,>=0.5.2

so after this we do not need manually update the min version as it adjusted during releasing process

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added the release label Jul 29, 2022
@Borda Borda added this to the all:next milestone Jul 29, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Jul 29, 2022
@Borda Borda marked this pull request as draft July 29, 2022 16:28
@Borda
Copy link
Collaborator Author

Borda commented Jul 29, 2022

shall be fixed with merging #13926

@Borda Borda marked this pull request as ready for review August 1, 2022 10:02
@Borda Borda requested a review from akihironitta as a code owner August 1, 2022 10:04
@Borda Borda requested a review from a team August 1, 2022 10:21
tchaton
tchaton approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Aug 1, 2022
@lexierule lexierule merged commit 47833df into master Aug 1, 2022
@lexierule lexierule deleted the pkg/requires branch August 1, 2022 13:08
Borda added a commit that referenced this pull request Aug 22, 2022
@Borda
pkg: parse local versions (#13933)
2076d09 
* pkg: parse local versions

* offline

* str

* manifest

* ci

(cherry picked from commit 47833df)
lantiga pushed a commit that referenced this pull request Aug 22, 2022
@Borda @lantiga
pkg: parse local versions (#13933)
69f78e1 
* pkg: parse local versions

* offline

* str

* manifest

* ci

(cherry picked from commit 47833df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

+2 more reviewers

@manskx manskx manskx approved these changes

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

app (removed) Generic label for Lightning App package ready PRs ready to be merged release

Projects

None yet

Milestone

all:next

Development

Successfully merging this pull request may close these issues.

5 participants

@Borda @manskx @tchaton @akihironitta @lexierule