Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated LoggerCollection #14283

Merged
merged 10 commits into from
Sep 12, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 18, 2022

What does this PR do?

Follow up to #14231
Resolves #12147

This also reverts #10232, which is no longer needed now that LoggerCollection is gone and user is forced to use self.loggers to access all logger instances.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @awaelchli @edward-io @Borda @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @tchaton @justusschock

@awaelchli awaelchli changed the title Remove deprecated logger collection Remove deprecated LoggerCollection Aug 18, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 18, 2022
@awaelchli awaelchli added logger Related to the Loggers breaking change Includes a breaking change deprecation Includes a deprecation and removed pl Generic label for PyTorch Lightning package labels Aug 18, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 18, 2022
@awaelchli awaelchli self-assigned this Aug 18, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 18, 2022
@awaelchli awaelchli marked this pull request as ready for review August 18, 2022 13:45
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 18, 2022
@mergify mergify bot removed the ready PRs ready to be merged label Aug 19, 2022
@awaelchli awaelchli requested a review from otaj as a code owner August 26, 2022 17:51
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Aug 26, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 12, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 12, 2022 20:34
@awaelchli awaelchli merged commit 4bd135a into master Sep 12, 2022
@awaelchli awaelchli deleted the refactor/remove-deprecated-logger-collection branch September 12, 2022 21:46
@awaelchli awaelchli mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation logger Related to the Loggers pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants