Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 22, 2022

What does this PR do?

resolving imports for ##9980

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7

@Borda Borda added the refactor label Aug 22, 2022
@Borda Borda added this to the all:next milestone Aug 22, 2022
@Borda Borda changed the title fix collections.abc for py3.10 fix imports of collections.abc for py3.10 Aug 22, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 22, 2022
@lexierule lexierule merged commit 99ba95a into master Aug 23, 2022
@lexierule lexierule deleted the fix/collections branch August 23, 2022 15:53
rohitgr7 pushed a commit that referenced this pull request Aug 23, 2022
fix collections.abc for py3.10

Co-authored-by: Sherin Thomas <sherin@grid.ai>
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
fix collections.abc for py3.10

Co-authored-by: Sherin Thomas <sherin@grid.ai>
lexierule pushed a commit that referenced this pull request Aug 25, 2022
fix collections.abc for py3.10

Co-authored-by: Sherin Thomas <sherin@grid.ai>
@Borda Borda self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants