Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 23, 2022

What does this PR do?

preparing RC

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added the release label Aug 23, 2022
@Borda Borda added this to the app:0.6 milestone Aug 23, 2022
@Borda Borda requested review from manskx and tchaton as code owners August 23, 2022 20:41
@Borda Borda requested review from a team, hhsecond and narJH27 August 23, 2022 20:42
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 23, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 23, 2022
@lantiga lantiga merged commit d8ba94b into master Aug 23, 2022
@lantiga lantiga deleted the dev/app branch August 23, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ready PRs ready to be merged release

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants