Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 30, 2022

What does this PR do?

This PR adds the missing documentation for the Lightning App configure_api / configure_commands.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@tchaton tchaton self-assigned this Aug 30, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 30, 2022
@tchaton tchaton added the docs Documentation related label Aug 30, 2022
@tchaton tchaton added this to the app:0.6 milestone Aug 30, 2022
@tchaton tchaton marked this pull request as ready for review August 30, 2022 15:20
@tchaton
Copy link
Contributor Author

tchaton commented Aug 30, 2022

Note for the reviewer: The Configure API docs will change once #14183 is merged

@tchaton tchaton requested a review from hhsecond as a code owner August 30, 2022 18:46
Copy link
Contributor

@Felonious-Spellfire Felonious-Spellfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made updates directly to the files.

@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2022
@Borda Borda enabled auto-merge (squash) August 31, 2022 19:12
tchaton and others added 2 commits August 31, 2022 21:17
@tchaton tchaton changed the title Add the docs for Commands / API Introduce lightning connect Aug 31, 2022
@lexierule lexierule disabled auto-merge August 31, 2022 19:58
@lexierule lexierule merged commit a7c01c4 into master Aug 31, 2022
@lexierule lexierule deleted the add_missing_docs branch August 31, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package docs Documentation related ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants