Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call LightningDataModule.load_state_dict hook while restoring checkpoint using LightningDataModule.load_from_checkpoint #14883

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Sep 24, 2022

What does this PR do?

Fixes #14842

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @awaelchli @ananthsub @ninginthecloud @rohitgr7 @otaj @carmocca @Borda @jjenniferdai @akihironitta

@rohitgr7 rohitgr7 added bug Something isn't working checkpointing Related to checkpointing lightningdatamodule pl.LightningDataModule labels Sep 24, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7.x milestone Sep 24, 2022
@rohitgr7 rohitgr7 self-assigned this Sep 24, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 24, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 24, 2022
@rohitgr7 rohitgr7 force-pushed the fix/dm_load_state_dict branch from a139bab to fa7c934 Compare September 24, 2022 12:45
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 24, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review September 24, 2022 18:59
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitgr7 There are _notebooks changes that were accidentally pushed :)

@mergify mergify bot added the ready PRs ready to be merged label Sep 27, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 enabled auto-merge (squash) September 29, 2022 13:38
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 29, 2022
@rohitgr7 rohitgr7 merged commit 3a70e5d into master Sep 29, 2022
@rohitgr7 rohitgr7 deleted the fix/dm_load_state_dict branch September 29, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checkpointing Related to checkpointing lightningdatamodule pl.LightningDataModule pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Datamodule not calling load_state_dict() when loading from checkpoint
4 participants