Call on_before_zero_grad model hook #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Apr 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
======================================
Coverage 91% 91%
======================================
Files 67 67
Lines 3753 3754 +1
======================================
+ Hits 3407 3408 +1
Misses 346 346 |
|
@PyTorchLightning/core-contributors I added the file "tests/trainer/test_hooks.py", is it ok? |
rather move them to tests/models |
|
This pull request is now in conflict... :( |
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
* call on_before_zero_grad * update changelog * add note about overriding both hooks * added test * move test_hooks.py to models folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
As reported in the issue fixes #1481 the on_before_zero_grad model hook was never called.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃