Do not lose references of trainer in test #15272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaj
requested review from
awaelchli,
carmocca,
justusschock and
rohitgr7
as code owners
carmocca
approved these changes
Oct 24, 2022
carmocca
changed the title
awaelchli
approved these changes
Oct 24, 2022
Merged
Borda
approved these changes
Oct 24, 2022
akihironitta
approved these changes
Oct 24, 2022
carmocca
force-pushed
the
ci/weakref_test
branch
from
d216beb to
f875a30
Compare
nicolai86
pushed a commit
that referenced
this pull request
Oct 25, 2022
* Fix reference error * Skip flaky hanging test * . Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the issue that surfaced in this comment #13638 (comment)
Hopefully fixes this PR #15231
cc @carmocca @akihironitta @Borda