Update pre-commit #15344

akihironitta · 2022-10-26T21:02:19Z

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[n/a] Did you verify new and existing tests pass locally with your changes?
[n/a] Did you list all the breaking changes introduced by this pull request?
[n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

for more information, see https://pre-commit.ci

src/pytorch_lightning/accelerators/accelerator.py

for more information, see https://pre-commit.ci

akihironitta · 2022-10-27T10:23:05Z

It turned out docformatter doesn't do well on the sphinx directive: PyCQA/docformatter#78

- .. deprecated:: v1.8.0
-     This hook was deprecated in v1.8.0 and will be removed in v1.10.0. Please use
-     ``setup_device()`` instead.
+ .. deprecated:: v1.8.0 This hook was deprecated in v1.8.0 and will be removed in v1.10.0. Please use
+ ``setup_device()`` instead.

Update: Found a workaround from @\carmocca here: #9422 (comment)

carmocca · 2022-11-12T17:25:24Z

Docs failures look real

github-actions · 2022-11-22T08:18:44Z

⛈️ Required checks status: Has failure 🔴

⚠️ This job will need to be re-run to merge your PR. If you do not have write access to the repository you can ask Lightning-AI/lai-frameworks to re-run it for you. If you push a new commit, all of CI will re-trigger ⚠️ If you have any other questions, you can reach out to carmocca for help.

Groups summary

🔴 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	failure	❌
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	failure	❌
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	failure	❌
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

🔴 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	failure	❌

🟢 lightning_lite: CPU workflow

Check ID	Status
lite-cpu (macOS-11, lite, 3.8, 1.11)	success	✅
lite-cpu (macOS-11, lite, 3.9, 1.12)	success	✅
lite-cpu (macOS-11, lite, 3.10, 1.13)	success	✅
lite-cpu (macOS-11, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (windows-2022, lite, 3.9, 1.11)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.12)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.13)	success	✅
lite-cpu (windows-2022, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
lite-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

🟢 lightning_lite: Azure GPU

Check ID	Status
lightning-lite (GPUs)	success	✅

🔴 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	failure	❌
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

🟢 mypy

Check ID	Status
mypy	success	✅

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, lite, 3.7)	success	✅
install-pkg (ubuntu-22.04, lite, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, lite, 3.7)	success	✅
install-pkg (macOS-12, lite, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, lite, 3.7)	success	✅
install-pkg (windows-2022, lite, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅

This comment was automatically generated and updates for 60 minutes every 180 seconds.

Thank you for your contribution! 💜

akihironitta · 2022-11-22T08:41:30Z

Let me finish this tomorrow (as it's a holiday tomorrow) or this weekend.

Borda · 2022-11-22T09:50:31Z

Let me finish this tomorrow (as it's a holiday tomorrow) or this weekend.

no rush, just checking :)

akihironitta · 2022-12-06T22:25:59Z

Closing this as I currently have no bandwith to finish this PR...

.pre-commit-config.yaml

carmocca · 2023-01-04T23:04:17Z

Opened #16257 so somebody finishes the docformatter upgrade. The other actions will be upgraded in #16224

Update versions in pre-commit config

911e921

akihironitta added this to the v1.9 milestone Oct 26, 2022

akihironitta requested a review from williamFalcon as a code owner October 26, 2022 21:02

akihironitta self-assigned this Oct 26, 2022

akihironitta requested review from Borda, tchaton, awaelchli, kaushikb11 and rohitgr7 as code owners October 26, 2022 21:02

[pre-commit.ci] auto fixes from pre-commit.com hooks

f0adefd

for more information, see https://pre-commit.ci

pre-commit-ci bot requested review from manskx, hhsecond, lantiga, carmocca, justusschock and otaj as code owners October 26, 2022 21:03

akihironitta and others added 2 commits October 27, 2022 06:08

Update versions further

9ac4a8f

[pre-commit.ci] auto fixes from pre-commit.com hooks

0c60e1b

for more information, see https://pre-commit.ci

akihironitta commented Oct 26, 2022

View reviewed changes

src/pytorch_lightning/accelerators/accelerator.py Outdated Show resolved Hide resolved

akihironitta and others added 2 commits October 27, 2022 06:22

Update black version for blacken-docs

4b5ccec

[pre-commit.ci] auto fixes from pre-commit.com hooks

52af133

for more information, see https://pre-commit.ci

pre-commit-ci bot requested a review from edenlightning as a code owner October 26, 2022 21:23

akihironitta marked this pull request as draft October 26, 2022 21:43

akihironitta added 2 commits October 27, 2022 17:52

Adjust formatting

ea4b583

Adjust formatting

668c22c

akihironitta marked this pull request as ready for review October 27, 2022 09:20

akihironitta added ci Continuous Integration code quality labels Oct 27, 2022

Fix flake8

3333d48

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 11, 2022

mergify bot added has conflicts and removed ready PRs ready to be merged labels Nov 21, 2022

Merge branch 'master' into ci/update-pre-commit

0251d75

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 22, 2022

akihironitta marked this pull request as draft November 22, 2022 08:40

auto-merge was automatically disabled November 22, 2022 08:40
Pull request was converted to draft

mergify bot removed the ready PRs ready to be merged label Nov 22, 2022

akihironitta closed this Dec 6, 2022

akihironitta deleted the ci/update-pre-commit branch December 6, 2022 22:26

Borda restored the ci/update-pre-commit branch December 7, 2022 07:04

Borda reopened this Dec 7, 2022

Borda self-assigned this Dec 7, 2022

carmocca reviewed Dec 12, 2022

View reviewed changes

.pre-commit-config.yaml Show resolved Hide resolved

This was referenced Jan 4, 2023

[pre-commit.ci] pre-commit suggestions #16224

Merged

Update the docformatter pre-commit action #16257

Open

carmocca closed this Jan 4, 2023

carmocca deleted the ci/update-pre-commit branch January 4, 2023 23:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pre-commit #15344

Update pre-commit #15344

akihironitta commented Oct 26, 2022 •

edited

Loading

akihironitta commented Oct 27, 2022 •

edited

Loading

carmocca commented Nov 12, 2022

github-actions bot commented Nov 22, 2022 •

edited

Loading

akihironitta commented Nov 22, 2022

Borda commented Nov 22, 2022

akihironitta commented Dec 6, 2022

carmocca commented Jan 4, 2023

Update pre-commit #15344

Update pre-commit #15344

Conversation

akihironitta commented Oct 26, 2022 • edited Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

akihironitta commented Oct 27, 2022 • edited Loading

carmocca commented Nov 12, 2022

github-actions bot commented Nov 22, 2022 • edited Loading

⛈️ Required checks status: Has failure 🔴

Groups summary

akihironitta commented Nov 22, 2022

Borda commented Nov 22, 2022

akihironitta commented Dec 6, 2022

carmocca commented Jan 4, 2023

akihironitta commented Oct 26, 2022 •

edited

Loading

akihironitta commented Oct 27, 2022 •

edited

Loading

github-actions bot commented Nov 22, 2022 •

edited

Loading