Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Resolve race condition to move ui files #15398

Merged
merged 9 commits into from
Nov 11, 2022
Merged

[App] Resolve race condition to move ui files #15398

merged 9 commits into from
Nov 11, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 28, 2022 •
edited by github-actions bot
Loading

What does this PR do?

The frontend shouldn't be written when instantiating the LightningApp.
This can lead to race conditions to the multi-processing aspect of Lightning App.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 28, 2022
@Borda
Copy link
Member

Borda commented Oct 28, 2022

some more context?

@tchaton tchaton added the bug Something isn't working label Nov 10, 2022
@tchaton tchaton added this to the v1.8.x milestone Nov 10, 2022
@tchaton tchaton changed the title Resolve race condition to move ui files [App] Resolve race condition to move ui files Nov 10, 2022
@tchaton tchaton self-assigned this Nov 10, 2022
@tchaton
Copy link
Contributor Author

tchaton commented Nov 10, 2022

some more context?

Added.

@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@tchaton tchaton enabled auto-merge (squash) November 10, 2022 19:13
@tchaton tchaton merged commit 2f0c039 into master Nov 11, 2022
@tchaton tchaton deleted the fix_race_condition branch November 11, 2022 10:15
Borda pushed a commit that referenced this pull request Nov 16, 2022
@tchaton @Borda
[App] Resolve race condition to move ui files (#15398)
d10430a 
(cherry picked from commit 2f0c039)
Borda pushed a commit that referenced this pull request Nov 16, 2022
@tchaton @Borda
[App] Resolve race condition to move ui files (#15398)
1f0e08a 
(cherry picked from commit 2f0c039)
williamFalcon added a commit that referenced this pull request Nov 18, 2022
@Borda @ethanwharris
@carmocca @tchaton @tshu-w @williamFalcon @awaelchli @lantiga @Atharva-Phatak @luca3rd @MarcSkovMadsen @aniketmaurya @rlizzo @edenlightning @function2-llx @yurijmikhalevich @dependabot @narJH27 @pre-commit-ci @yiftachbeer @dymil
Releasing 1.8.2 [rebase & merge] (#15698)
8bea72b 
* chlog update

* mypy: ignore mypy serve (#15631)

(cherry picked from commit 38f2a91)

* Enable Probot CheckGroup v3 (#15622)

(cherry picked from commit bd870c6)

* [App] Enable state broadcast with MultiNode (#15607)

(cherry picked from commit 61c1f69)

* [App] Resolve race condition to move ui files (#15398)

(cherry picked from commit 2f0c039)

* Make sure save_dir can be empty str (#15638)

(cherry picked from commit c53dc20)

* [App] Resolve bi-directional queue bug (#15642)

(cherry picked from commit 0250c19)

* Refactor checkgroup to avoid duplicated checks (#15633)

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 1954764)

* Delete unused TPU CI files (#15611)

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit a3edbec)

* Update run_ptl_script.py

(cherry picked from commit 4e8cf85)

* [App] Accelerate Multi Node Startup Time (#15650)

(cherry picked from commit 757413c)

* [App] Change app root / config path to be the `app.py` parent directory (#15654)

* Change app root / config path to be the `app.py` parent directory

* Update CHANGELOG.md

* mypy

* Fix

* Mypy

(cherry picked from commit b3281eb)

* Add LightningLite to top level imports (#15502)

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
(cherry picked from commit c32c435)

* Upgrade GPU CI to PyTorch 1.13 (#15583)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>

(cherry picked from commit e87c11a)

* Prevent artifactual "running from outside your current environment" error (#15647)

Prevent warning when shutil.executable returns a symlink

Co-authored-by: Luca Antiga <luca@lightning.ai>
(cherry picked from commit 3248f33)

* Fix ddp_spawn -> ddp fallback logic when on LSF cluster (#15657)

Co-authored-by: awaelchli <aedu.waelchli@gmail.com>

(cherry picked from commit cdb7006)

* Include images with the mirror package (#15659)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
(cherry picked from commit c06ea41)

* [App] Rename failed -> error in tables (#15608)

Co-authored-by: Raphael Randschau <nicolai86@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
(cherry picked from commit ca83b50)

* Improves the PanelFrontend docs (#14493)

Co-authored-by: Marc Skov Madsen <masma@orsted.dk>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Felonious-Spellfire <felonious.spellfire@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Mansy <ahmed.mansy156@gmail.com>
(cherry picked from commit 10a4b24)

* add title and description to ServeGradio (#15639)

* add title and description
* update test
* apply suggestions

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit f9d906c)

* Upgrade CI to PyTorch 1.13 (#15403)

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

(cherry picked from commit 57ac548)

* Fixed Import in Docs For Multinode Trainer Name Which does Not Exist (#15663)

(cherry picked from commit 23f88cd)

* Validate the combination of CloudCompute and BuildConfig (#14929)

Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
(cherry picked from commit e5a865c)

* add contributing guide to readme

(cherry picked from commit 98af2bb)

* Add Python 3.10 badge (#15681)

(cherry picked from commit 8f44bb5)

* fix(docs/app): broken links in the intermediate/web-ui section (#15691)

(cherry picked from commit 4837df4)

* Bump google-github-actions/setup-gcloud from 0 to 1 (#15671)

Bumps [google-github-actions/setup-gcloud](https://github.com/google-github-actions/setup-gcloud) from 0 to 1.
- [Release notes](https://github.com/google-github-actions/setup-gcloud/releases)
- [Changelog](https://github.com/google-github-actions/setup-gcloud/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/setup-gcloud@v0...v1)

---
updated-dependencies:
- dependency-name: google-github-actions/setup-gcloud
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit c451288)

* Update onnxruntime requirement from <1.13.0 to <1.14.0 in /requirements (#15672)

Updates the requirements on [onnxruntime](https://github.com/microsoft/onnxruntime) to permit the latest version.
- [Release notes](https://github.com/microsoft/onnxruntime/releases)
- [Changelog](https://github.com/microsoft/onnxruntime/blob/main/docs/ReleaseManagement.md)
- [Commits](microsoft/onnxruntime@v0.1.4...v1.13.1)

---
updated-dependencies:
- dependency-name: onnxruntime
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 7a8e2e9)

* Bump google-github-actions/auth from 0 to 1 (#15675)

Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 0 to 1.
- [Release notes](https://github.com/google-github-actions/auth/releases)
- [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/auth@v0...v1)

---
updated-dependencies:
- dependency-name: google-github-actions/auth
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit e93c649)

* Docs: Fix import for scikit in XGBoost template (#15693)

(cherry picked from commit 9670fa8)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Enable Probot CheckGroup v4 (#15649)

(cherry picked from commit 80e7538)

* docs 5/n (#15669)

* examples

* fix few examples

* Update pl_multinode.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 41f1a36)

* fix(docs/app/lit_tabs): remove unused app_id, enable run instead (#15702)

(cherry picked from commit befd3f6)

* [App] Mock missing package imports when launching in the cloud (#15711)

Co-authored-by: manskx <ahmed.mansy156@gmail.com>
(cherry picked from commit f57160b)

* Fix catimage import (#15712)

(cherry picked from commit ee517f3)

* Parse all lines in app file looking for shebangs to run commands. (#15714)

fixed command parsing so that all lines in the file are parsed

(cherry picked from commit 98bcb3d)

* Bump coverage from 6.4.2 to 6.5.0 in /requirements (#15674)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 6.4.2 to 6.5.0.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@6.4.2...6.5.0)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 13eb2a1)

* remove unused random_split import from tutorial (#15716)

(cherry picked from commit b40ca0e)

* Fix typo 'wether' (#15710)

(cherry picked from commit 609b258)

* releasing 1.8.2

Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Tianshu Wang <wang@tianshu.me>
Co-authored-by: William Falcon <waf2107@columbia.edu>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
Co-authored-by: Atharva Phatak <athp456@gmail.com>
Co-authored-by: Luca Furst <rlfurst@gmail.com>
Co-authored-by: Marc Skov Madsen <marc.skov.madsen@gmail.com>
Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com>
Co-authored-by: Rick Izzo <rlizzo@users.noreply.github.com>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
Co-authored-by: 罗崚骁(LUO Lingxiao) <function2-llx@outlook.com>
Co-authored-by: Yurij Mikhalevich <yurij@grid.ai>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nash <nash@lightning.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: yiftachbeer <yiftach.beer@gmail.com>
Co-authored-by: dymil <30931139+dymil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@lantiga lantiga lantiga approved these changes

@hhsecond hhsecond Awaiting requested review from hhsecond

@awaelchli awaelchli Awaiting requested review from awaelchli

@manskx manskx Awaiting requested review from manskx

Assignees

@tchaton tchaton

Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@tchaton @Borda @lantiga @ethanwharris