Do not modify MANIFEST.in on install #15549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
Borda,
akihironitta,
awaelchli,
justusschock,
kaushikb11,
lantiga,
manskx,
otaj,
rohitgr7,
tchaton and
williamFalcon
as code owners
carmocca
changed the title
carmocca
commented
Nov 5, 2022
Borda
approved these changes
Nov 6, 2022
mergify
bot
added
ready
This reverts commit 5f8938b.
Contributor
Author
|
Something here is making e2e examples hang. Haven't found the cause... |
mergify
bot
added
ready
lantiga
pushed a commit
that referenced
this pull request
Nov 11, 2022
carmocca
added a commit
that referenced
this pull request
Nov 11, 2022
Collaborator
|
Just curious, why this had to be reverted? 🤔 |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #15474
Each package keeps it's own MANIFEST.in
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @carmocca @akihironitta @Borda