-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Dockerfile #1569
Create Dockerfile #1569
Conversation
docker/Dockerfile
Outdated
@@ -0,0 +1,40 @@ | |||
ARG CUDA_VERSION=10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are older pytorch version compatible? I remember that a month ago even 1.4 supports cuda 10.1 and 9.2 only
There was also a comment that that from pt 1.5 they support cuda 10.2
So maybe add a test call if installed pytorch accesses cuda correctly so we don't produce useless images...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't matter, since pytorch also comes with precompiled cuda. I chose that, since this is the version that may be used, if somebody wants to compile custom stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be important for Horovod and I believe Apex/AMP, as they both compile from CUDA source.
docker build currently fails, since horovod guys have a hard torch vision dependency, that installs unrestricted torch vision (defaults to latest if not specified by us): horovod/horovod#1898 |
Hey @justusschock @williamFalcon, I'll make a PR to remove the torchvision dep. But in the meantime, as I mentioned in the other thread, you should be able to change |
we just did in #1573 |
failed to build:
|
Just a small typo. Fixed this :) |
@williamFalcon can we merge this? |
Before submitting
What does this PR do?
Adds a docker file to
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃