Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document running a local version of lightning on the cloud #15962

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Document running a local version of lightning on the cloud #15962

merged 7 commits into from
Dec 9, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Dec 8, 2022 •
edited by github-actions bot
Loading

What does this PR do?

See title.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@akihironitta akihironitta added docs Documentation related app (removed) Generic label for Lightning App package labels Dec 8, 2022
@akihironitta akihironitta self-assigned this Dec 8, 2022
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Dec 8, 2022
@akihironitta akihironitta added this to the v1.9 milestone Dec 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

nohalon
nohalon reviewed Dec 8, 2022
View reviewed changes
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
Borda
Borda approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still need to have it install with -e as pip install -e .

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@Borda Borda requested a review from nohalon December 8, 2022 17:40
@akihironitta akihironitta force-pushed the docs/app-contributing branch from f2d25c3 to e1cb436 Compare December 8, 2022 18:27
@akihironitta akihironitta force-pushed the docs/app-contributing branch from b257470 to 38c2b26 Compare December 8, 2022 18:28
@akihironitta akihironitta enabled auto-merge (squash) December 8, 2022 18:28
@akihironitta
Copy link
Contributor Author

do you still need to have it install with -e as pip install -e .

The use case of this env var I see is for developers who make changes to the lightning codebase, so I put -e in the guide there. Feel free to make any changes if you have another idea :)

@akihironitta akihironitta added the app (removed) Generic label for Lightning App package label Dec 8, 2022
@akihironitta akihironitta changed the title Document running dev lightning on the cloud Document running a local version of lightning on the cloud Dec 9, 2022
nohalon
nohalon reviewed Dec 9, 2022
View reviewed changes
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
nohalon
nohalon approved these changes Dec 9, 2022
View reviewed changes
.github/CONTRIBUTING.md Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2022
@akihironitta @nohalon
Update .github/CONTRIBUTING.md
40fb7ad 
Co-authored-by: Noha Alon <nohalon@gmail.com>
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Dec 9, 2022
@akihironitta akihironitta merged commit cfd00d3 into master Dec 9, 2022
@akihironitta akihironitta deleted the docs/app-contributing branch December 9, 2022 14:13
Borda pushed a commit that referenced this pull request Dec 9, 2022
@akihironitta @Borda
Document running dev lightning on the cloud (#15962)
5f862fd 
* document running dev lightning on the cloud

* document running dev lightning on the cloud

* Update .github/CONTRIBUTING.md

Co-authored-by: Noha Alon <nohalon@gmail.com>

* document running dev lightning on the cloud

* git clone & pip install -e

* Update .github/CONTRIBUTING.md

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Co-authored-by: Noha Alon <nohalon@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit cfd00d3)
lantiga added a commit that referenced this pull request Dec 9, 2022
@Borda @lantiga
@tchaton @akihironitta @Liyang90 @justusschock @ethanwharris
Releasing/1.8.4.post (#15988)
6a39743 
* Apply dynamo to training_step, validation_step, test_step, predict_step (#15957)

* Apply dynamo to training_step, validation_step, test_step, predict_step

* Add entry to CHANGELOG.md

(cherry picked from commit edc9986)

* [App] Resolve run installation (#15974)

(cherry picked from commit dd83587)

* App: Move AutoScaler dependency to extra requirements (#15971)

* Make autoscaler dependency optional
* update chglog
* dont directly import aiohttp

(cherry picked from commit 346e936)

# Conflicts:
#	requirements/app/base.txt
#	src/lightning_app/CHANGELOG.md

* Avoid using the same port number for autoscaler works (#15966)

* dont hardcode port in python server
* add another chglog

(cherry picked from commit a72d268)

* Fix `action_name` usage in `XLAProfiler` (#15886)

* Fix `action_name` usage in `XLAProfiler`
* add changelog
* Update src/pytorch_ligh
* Update xla.py

Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit c748f82)

* Fix multinode cloud component (#15965)

* fix multinode cloud component
* add tests

(cherry picked from commit d21b899)

* ci: update signaling (#15981)

* ci: update signaling
* config

(cherry picked from commit e56e7f1)

* Fix cloudcomputes registration for structures (#15964)

* fix cloudcomputes
* updates cloudcompute registration
* changelog

(cherry picked from commit 90a4c02)

* Document running dev lightning on the cloud (#15962)

* document running dev lightning on the cloud

* document running dev lightning on the cloud

* Update .github/CONTRIBUTING.md

Co-authored-by: Noha Alon <nohalon@gmail.com>

* document running dev lightning on the cloud

* git clone & pip install -e

* Update .github/CONTRIBUTING.md

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Co-authored-by: Noha Alon <nohalon@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit cfd00d3)

* [App] Install exact version whn upgrading and not when testing (#15984)

* [App] Install exact version whn upgrading and not when testing
* Update CHANGELOG.md

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 1657ea8)

* releasing 1.8.4.post0

Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Liyang90 <liyanglu@google.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@nohalon nohalon nohalon approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

Assignees

@akihironitta akihironitta

Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@akihironitta @Borda @nohalon