Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Improve PythonServer info message on startup #15989

Merged
merged 10 commits into from
Dec 20, 2022
Merged

[App] Improve PythonServer info message on startup #15989

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
190eba9
change msg
akihironitta Dec 9, 2022
16f65d0
change msg
akihironitta Dec 9, 2022
5fc4968
update chgl
akihironitta Dec 9, 2022
0ef08c1
show the user's class name
akihironitta Dec 9, 2022
c6e2c30
Merge branch 'master' into bugfix/python-serve-startup-msg
akihironitta Dec 9, 2022
9e2c237
Merge branch 'master' into bugfix/python-serve-startup-msg
Borda Dec 10, 2022
34fc49c
Merge branch 'master' into bugfix/python-serve-startup-msg
Borda Dec 12, 2022
3df7abc
Merge branch 'master' into bugfix/python-serve-startup-msg
akihironitta Dec 13, 2022
b349d00
Update src/lightning_app/CHANGELOG.md
akihironitta Dec 13, 2022
5127026
Merge branch 'master' into bugfix/python-serve-startup-msg
akihironitta Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lightning_app/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed Registration for CloudComputes of Works in `L.app.structures` ([#15964](https://github.com/Lightning-AI/lightning/pull/15964))


- Fixed `PythonServer` messaging "Your app has started" ([#15989](https://github.com/Lightning-AI/lightning/pull/15989))


akihironitta marked this conversation as resolved.
Show resolved Hide resolved
## [1.8.4] - 2022-12-08

### Added
Expand Down
4 changes: 3 additions & 1 deletion src/lightning_app/components/serve/python_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,5 +227,7 @@ def run(self, *args: Any, **kwargs: Any) -> Any:
fastapi_app = FastAPI()
self._attach_predict_fn(fastapi_app)

logger.info(f"Your app has started. View it in your browser: http://{self.host}:{self.port}")
logger.info(
f"Your {self.__class__.__qualname__} has started. View it in your browser: http://{self.host}:{self.port}"
)
uvicorn.run(app=fastapi_app, host=self.host, port=self.port, log_level="error")