New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont try to update an instance that isnt running yet #15998

Merged

tchaton merged 4 commits into master from bugfix/wait_for_running

Dec 9, 2022

Member

ethanwharris commented Dec 9, 2022 •

edited by github-actions bot

Loading

What does this PR do?

There is a bug where we can try to update an instance that hasn't technically started running yet - this fixes it to not update unless we are running

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃


          Dont try to update an instance that isnt running yet

abf5d7b

ethanwharris requested review from tchaton, lantiga, awaelchli and hhsecond as code owners

December 9, 2022 21:50

github-actions bot added the app (removed) label

Contributor

github-actions bot commented Dec 9, 2022 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/app.py, src/lightning_app/utilities/app_helpers.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/app.py, src/lightning_app/utilities/app_helpers.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/app.py, src/lightning_app/utilities/app_helpers.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/app.py, src/lightning_app/utilities/app_helpers.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/app.py, src/lightning_app/utilities/app_helpers.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, lite, 3.7)	success	✅
install-pkg (ubuntu-22.04, lite, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, lite, 3.7)	success	✅
install-pkg (macOS-12, lite, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, lite, 3.7)	success	✅
install-pkg (windows-2022, lite, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/app.py, src/lightning_app/utilities/app_helpers.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Fix

224ba23

ethanwharris added the bug label

ethanwharris commented

View reviewed changes

src/lightning_app/utilities/app_helpers.py Outdated Show resolved Hide resolved


          Update src/lightning_app/utilities/app_helpers.py

73d46bd

hhsecond reviewed

View reviewed changes

src/lightning_app/core/app.py Show resolved Hide resolved


          [pre-commit.ci] auto fixes from pre-commit.com hooks

a4bba6b

for more information, see https://pre-commit.ci

hhsecond approved these changes

View reviewed changes

tchaton approved these changes

View reviewed changes

Contributor

tchaton left a comment

LGTM !

tchaton merged commit 5595166 into master

tchaton deleted the bugfix/wait_for_running branch

December 9, 2022 22:22

mergify bot added the ready label

ethanwharris added a commit that referenced this pull request


          Dont try to update an instance that isnt running yet (#15998)

0f7c608

williamFalcon pushed a commit that referenced this pull request


          1.8.4.post release final (#15999)

60b3cc9

* Dont try to update an instance that isnt running yet (#15998)

* Fix hanging CI

Co-authored-by: Sherin Thomas <sherin@lightning.ai>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) bug ready