-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sys.argv and args in LightningCLI #16808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erotemic
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
February 19, 2023 18:25
awaelchli
added
community
This PR is from the community
lightningcli
pl.cli.LightningCLI
labels
Feb 19, 2023
carmocca
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing test needs to be updated
for more information, see https://pre-commit.ci
carmocca
approved these changes
Mar 7, 2023
awaelchli
approved these changes
Mar 7, 2023
Borda
pushed a commit
that referenced
this pull request
Mar 30, 2023
(cherry picked from commit 0ec44f1)
Borda
pushed a commit
that referenced
this pull request
Mar 30, 2023
(cherry picked from commit 0ec44f1)
lantiga
pushed a commit
that referenced
this pull request
Apr 3, 2023
(cherry picked from commit 0ec44f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
This PR is from the community
lightningcli
pl.cli.LightningCLI
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently this just changes an error into a warning. An alternative would be to let the user specify a flag that changed the error into a warning, but my thought is that might just be more clutter than what it's worth, raising the warning might be good enough.
Fixes #16807
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist