Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sys.argv and args in LightningCLI #16808

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

Erotemic
Copy link
Contributor

@Erotemic Erotemic commented Feb 19, 2023

What does this PR do?

Currently this just changes an error into a warning. An alternative would be to let the user specify a flag that changed the error into a warning, but my thought is that might just be more clutter than what it's worth, raising the warning might be good enough.

Fixes #16807

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 19, 2023
@awaelchli awaelchli added community This PR is from the community lightningcli pl.cli.LightningCLI labels Feb 19, 2023
@carmocca carmocca self-assigned this Feb 20, 2023
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing test needs to be updated

src/lightning/pytorch/cli.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added this to the 2.0 milestone Mar 7, 2023
@mergify mergify bot added the ready PRs ready to be merged label Mar 7, 2023
@awaelchli awaelchli merged commit 0ec44f1 into Lightning-AI:master Mar 7, 2023
Borda pushed a commit that referenced this pull request Mar 30, 2023
Borda pushed a commit that referenced this pull request Mar 30, 2023
lantiga pushed a commit that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sys.argv and args with LightningCLI for testing
3 participants