-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for ShardedTensor deprecation #16892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
refactor
breaking change
Includes a breaking change
lightningmodule
pl.LightningModule
labels
Feb 28, 2023
carmocca
requested review from
awaelchli,
justusschock,
williamFalcon and
tchaton
as code owners
February 28, 2023 01:57
github-actions
bot
added
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
labels
Feb 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16892 +/- ##
=========================================
- Coverage 82% 59% -22%
=========================================
Files 436 412 -24
Lines 31519 31215 -304
=========================================
- Hits 25784 18514 -7270
- Misses 5735 12701 +6966 |
awaelchli
approved these changes
Mar 1, 2023
justusschock
approved these changes
Mar 3, 2023
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Mar 3, 2023
Borda
pushed a commit
that referenced
this pull request
Mar 30, 2023
(cherry picked from commit a00e061)
lantiga
pushed a commit
that referenced
this pull request
Apr 3, 2023
(cherry picked from commit a00e061)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
lightningmodule
pl.LightningModule
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PyTorch plans to deprecate ShardedTensor in favor of DistributedTensor in 2.1, with removal in 2.2
Since we import it on
LightningModule
instantiation, we need this to avoid the deprecation warning.ShardedTensor support is experimental.
First noticed in pytorch/pytorch#95453
cc @justusschock @awaelchli @Borda @carmocca