Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mypy job to torch 2.0 #16933

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Update mypy job to torch 2.0 #16933

merged 4 commits into from
Mar 6, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 3, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Re-do of #16930

cc @carmocca @akihironitta @Borda @justusschock @awaelchli

@carmocca carmocca added ci Continuous Integration refactor pl Generic label for PyTorch Lightning package labels Mar 3, 2023
@carmocca carmocca added this to the 2.0 milestone Mar 3, 2023
@carmocca carmocca self-assigned this Mar 3, 2023
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (macOS-11, lightning, 3.9, 2.0, pre) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre) success ✅
pl-cpu (windows-2022, lightning, 3.9, 1.11) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.12) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.0, pre) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/distributed.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/distributed.py, src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/distributed.py.

🟢 fabric: Docs
Check ID Status
make-doctest (fabric) success ✅
make-html (fabric) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/distributed.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 1.11) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.12) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to .github/workflows/code-checks.yml, requirements/typing.txt, src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/distributed.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/parallel.py, src/lightning/fabric/utilities/cloud_io.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/distributed.py, requirements/typing.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Borda
Borda approved these changes Mar 3, 2023
View reviewed changes
requirements/typing.txt Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited
Loading

Codecov Report

Merging #16933 (fd84be9) into master (54147e0) will decrease coverage by 22%.
The diff coverage is 67%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #16933     +/-   ##
=========================================
- Coverage      82%      59%    -22%     
=========================================
  Files         439      414     -25     
  Lines       31688    31393    -295     
=========================================
- Hits        25917    18635   -7282     
- Misses       5771    12758   +6987

@carmocca carmocca enabled auto-merge (squash) March 6, 2023 15:55
@carmocca carmocca merged commit c2b28a0 into master Mar 6, 2023
@carmocca carmocca deleted the mypy/torch-2.0 branch March 6, 2023 16:54
@carmocca carmocca mentioned this pull request Mar 6, 2023
Merged
Borda pushed a commit that referenced this pull request Mar 30, 2023
@carmocca @Borda
Update mypy job to torch 2.0 (#16933)
9716ed0 
(cherry picked from commit c2b28a0)
Borda pushed a commit that referenced this pull request Mar 30, 2023
@carmocca @Borda
Update mypy job to torch 2.0 (#16933)
1124219 
(cherry picked from commit c2b28a0)
Borda pushed a commit that referenced this pull request Mar 30, 2023
@carmocca @Borda
Update mypy job to torch 2.0 (#16933)
6d4303f 
(cherry picked from commit c2b28a0)
lantiga pushed a commit that referenced this pull request Apr 3, 2023
@carmocca @lantiga
Update mypy job to torch 2.0 (#16933)
cdbd9fd 
(cherry picked from commit c2b28a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

@carmocca carmocca

Labels
ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@carmocca @awaelchli @Borda @justusschock @akihironitta