Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for torch.compile() with Fabric.setup() #16977

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Add test for torch.compile() with Fabric.setup() #16977

merged 3 commits into from
Mar 7, 2023

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Mar 6, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Adds a test for passing a compiled model to Fabric.

Fixes #16971

cc @carmocca @justusschock @awaelchli @Borda

@awaelchli awaelchli added fabric lightning.fabric.Fabric tests labels Mar 6, 2023
@awaelchli awaelchli added this to the 2.0 milestone Mar 6, 2023
@awaelchli awaelchli marked this pull request as ready for review March 6, 2023 21:10
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 1.11) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.12) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅

These checks are required after the changes to tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Mar 7, 2023
@awaelchli awaelchli merged commit b6c693d into master Mar 7, 2023
@awaelchli awaelchli deleted the tests/fabric-compile-setup branch March 7, 2023 15:57
Borda pushed a commit that referenced this pull request Mar 30, 2023
@awaelchli @Borda
Add test for torch.compile() with Fabric.setup() (#16977)
92d1c9f 
(cherry picked from commit b6c693d)
lantiga pushed a commit that referenced this pull request Apr 3, 2023
@awaelchli @lantiga
Add test for torch.compile() with Fabric.setup() (#16977)
4ccf3fc 
(cherry picked from commit b6c693d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

Assignees
No one assigned
Labels
fabric lightning.fabric.Fabric ready PRs ready to be merged tests torch.compile
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Add torch.compile tests with Fabric
4 participants
@awaelchli @Borda @carmocca @justusschock