New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline the `ModelIO` interface #16999

Merged

carmocca merged 2 commits into master from carmocca/modelio

Mar 8, 2023

Contributor

carmocca commented Mar 8, 2023 •

edited by github-actions bot

Loading

What does this PR do?

Part of #16974

ModelIO is not necessary anymore and it adds a level of misdirection to those reading the LightningModule

cc @justusschock @awaelchli @Borda @carmocca


          Inline the ModelIO interface

f4242ab

carmocca added refactor breaking change lightningmodule pl labels

carmocca added this to the 2.0 milestone

carmocca self-assigned this

carmocca requested review from williamFalcon, tchaton, awaelchli, justusschock, edenlightning, lantiga and Borda as code owners

March 8, 2023 16:51

Contributor

github-actions bot commented Mar 8, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/mixins/hparams_mixin.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/mixins/hparams_mixin.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/mixins/hparams_mixin.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/mixins/hparams_mixin.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py, docs/source-pytorch/api_references.rst, docs/source-pytorch/common/checkpointing_intermediate.rst.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/pytorch/core/mixins/hparams_mixin.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/mixins/hparams_mixin.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning/pytorch/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

carmocca changed the title ~~Inline the ModelIO interface~~ Inline the ModelIO interface


          CHANGELOG

cd55e6e

justusschock approved these changes

View reviewed changes

awaelchli approved these changes

View reviewed changes

mergify bot added the ready label

carmocca merged commit 3328b04 into master

carmocca deleted the carmocca/modelio branch

March 8, 2023 17:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

justusschock justusschock approved these changes

awaelchli awaelchli approved these changes

williamFalcon Awaiting requested review from williamFalcon

tchaton Awaiting requested review from tchaton tchaton is a code owner

edenlightning Awaiting requested review from edenlightning

lantiga Awaiting requested review from lantiga lantiga is a code owner

Borda Awaiting requested review from Borda Borda is a code owner

Labels

breaking change lightningmodule pl ready refactor