Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adjust is_timing_close #17178

Merged
merged 8 commits into from
Mar 24, 2023
Merged

test: adjust is_timing_close #17178

merged 8 commits into from
Mar 24, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 23, 2023

What does this PR do?

Trying to address noise in measurement...
assume we run the same, let's take the faster run to compare
follow-up work of #16899

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @justusschock @awaelchli @Borda

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Mar 23, 2023
@Borda Borda changed the title is_timing_close test: adjust is_timing_close Mar 23, 2023
@Borda Borda enabled auto-merge (squash) March 23, 2023 12:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11) success
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success

These checks are required after the changes to tests/tests_fabric/parity/test_parity_ddp.py, tests/tests_fabric/parity/test_parity_simple.py, tests/tests_fabric/parity/utils.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success

These checks are required after the changes to tests/tests_fabric/parity/test_parity_ddp.py, tests/tests_fabric/parity/test_parity_simple.py, tests/tests_fabric/parity/utils.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda added the tests label Mar 23, 2023
@Borda Borda requested a review from a team March 23, 2023 12:32
@Borda
Copy link
Member Author

Borda commented Mar 23, 2023

The case with lightning is addressed in #17170

@Borda Borda requested a review from awaelchli March 23, 2023 22:33
Borda and others added 2 commits March 24, 2023 11:32
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@Borda Borda merged commit 355dd9d into master Mar 24, 2023
@Borda Borda deleted the test/is_timing_close branch March 24, 2023 12:07
@mergify mergify bot added the ready PRs ready to be merged label Mar 24, 2023
@carmocca carmocca added this to the 2.0.x milestone Mar 30, 2023
carmocca pushed a commit that referenced this pull request Mar 30, 2023
lantiga pushed a commit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants