requires onnx & ci adjustment #17208

Borda · 2023-03-27T18:55:44Z

What does this PR do?

adding ONNX as requirements for compatibility

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @akihironitta @tchaton

github-actions · 2023-03-27T18:56:23Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/pytorch/test.txt, src/pytorch_lightning/core/module.py, src/pytorch_lightning/utilities/imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to requirements/pytorch/test.txt, src/pytorch_lightning/core/module.py, src/pytorch_lightning/utilities/imports.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	success	✅

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to requirements/pytorch/test.txt, src/pytorch_lightning/core/module.py, src/pytorch_lightning/utilities/imports.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/utilities/imports.py, requirements/pytorch/test.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.8, 1.10, 11.3.1)	success	✅
build-cuda (3.8, 1.11, 11.3.1)	success	✅
build-cuda (3.8, 1.12, 11.3.1)	success	✅
build-cuda (3.8, 1.13, 11.6.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.10)	success	✅
build-NGC	success	✅
build-pl (3.8, 1.10, 11.3.1)	success	✅
build-pl (3.8, 1.11, 11.3.1)	success	✅
build-pl (3.8, 1.12, 11.3.1)	success	✅
build-pl (3.8, 1.13, 11.6.1)	success	✅
build-xla (3.7, 1.12)	success	✅

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/pytorch/test.txt, src/pytorch_lightning/core/module.py, src/pytorch_lightning/utilities/imports.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/utilities/imports.py, requirements/pytorch/test.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

…h-lightning into fix/onnx

src/pytorch_lightning/core/module.py

for more information, see https://pre-commit.ci

akihironitta

The CI change LGTM!

require: onnx

b0e0436

Borda added 3rd party Related to a 3rd-party priority: 1 Medium priority task labels Mar 27, 2023

Borda added this to the v1.9.x milestone Mar 27, 2023

Borda requested review from lantiga, tchaton and awaelchli as code owners March 27, 2023 18:55

github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 27, 2023

Borda requested a review from a team March 27, 2023 18:56

Borda enabled auto-merge (squash) March 27, 2023 18:56

awaelchli approved these changes Mar 27, 2023

View reviewed changes

Borda mentioned this pull request Mar 27, 2023

docs: fix links #17197

Merged

7 tasks

Borda requested review from akihironitta, carmocca, ethanwharris and a team March 27, 2023 21:01

doctest

3363ed4

Borda requested a review from williamFalcon as a code owner March 27, 2023 21:10

Borda and others added 3 commits March 27, 2023 23:16

Merge branch 'release/LTS' into fix/onnx

3377a44

doctest

cbe5fb8

Merge branch 'fix/onnx' of https://github.com/PyTorchLightning/pytorc…

f055150

…h-lightning into fix/onnx

Borda commented Mar 27, 2023

View reviewed changes

src/pytorch_lightning/core/module.py Outdated Show resolved Hide resolved

doctest

6c4e100

Borda requested a review from justusschock as a code owner March 27, 2023 21:29

pre-commit-ci bot and others added 2 commits March 27, 2023 21:30

[pre-commit.ci] auto fixes from pre-commit.com hooks

42995cb

for more information, see https://pre-commit.ci

py3.8

19b04d6

github-actions bot added the ci Continuous Integration label Mar 28, 2023

Borda added 2 commits March 28, 2023 08:37

pt

bb9293d

gc

0b6c35f

ipu

af2f347

Borda changed the title ~~require: onnx~~ requires onnx & ci adjustment Mar 28, 2023

akihironitta approved these changes Mar 28, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Mar 28, 2023

justusschock approved these changes Mar 28, 2023

View reviewed changes

Borda merged commit 571ffd8 into release/LTS Mar 28, 2023

Borda deleted the fix/onnx branch March 28, 2023 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

requires onnx & ci adjustment #17208

requires onnx & ci adjustment #17208

Borda commented Mar 27, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

akihironitta left a comment

requires onnx & ci adjustment #17208

requires onnx & ci adjustment #17208

Conversation

Borda commented Mar 27, 2023 • edited by github-actions bot Loading

What does this PR do?

PR review

github-actions bot commented Mar 27, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

akihironitta left a comment

Choose a reason for hiding this comment

Borda commented Mar 27, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading