Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy from src/lightning/pytorch and use torch only #17278

Merged
merged 36 commits into from
Apr 15, 2023

Conversation

ishandutta0098
Copy link
Contributor

@ishandutta0098 ishandutta0098 commented Apr 4, 2023

What does this PR do?

This PR is a part of #16649
I have removed the numpy requirement from the files within src/lightning/pytorch including:

  • simple.py
  • model_summary.py

The numpy requirement has also been removed for lr_finder.py, it is in an older PR: #17264

Both these PRs shall enable to replace numpy with torch for all files within src/lightning/pytorch

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 4, 2023
@ishandutta0098 ishandutta0098 marked this pull request as ready for review April 6, 2023 19:19
src/lightning/pytorch/loggers/logger.py Outdated Show resolved Hide resolved
src/lightning/pytorch/loggers/logger.py Outdated Show resolved Hide resolved
src/lightning/pytorch/loggers/logger.py Outdated Show resolved Hide resolved
src/lightning/pytorch/profilers/simple.py Outdated Show resolved Hide resolved
src/lightning/pytorch/profilers/simple.py Outdated Show resolved Hide resolved
src/lightning/pytorch/loggers/logger.py Outdated Show resolved Hide resolved
@carmocca carmocca added refactor community This PR is from the community labels Apr 10, 2023
src/lightning/pytorch/profilers/simple.py Outdated Show resolved Hide resolved
src/lightning/pytorch/profilers/simple.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added this to the 2.1 milestone Apr 11, 2023
@mergify mergify bot added the ready PRs ready to be merged label Apr 11, 2023
@awaelchli awaelchli enabled auto-merge (squash) April 12, 2023 16:19
@awaelchli awaelchli merged commit 9becc15 into Lightning-AI:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants