-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upload checkpoint files to neptune from stream #17430
upload checkpoint files to neptune from stream #17430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @AleksanderWWW
I left a comment for fixing the tests, let me know if you need help with it.
We could also add an entry in the changelog in src/lightning/pytorch/CHANGELOG.md
in the "#Fixed" section. Thanks!
@awaelchli Thank you for the feedback! Let me know if the relevant commit is enough to move forward, or if there's anything else I should do :) |
Tests are failing. They need to be fixed FAILED loggers/test_all.py::test_loggers_fit_test_all[NeptuneLogger] - AttributeError: 'NoneType' object has no attribute 'from_stream'
FAILED loggers/test_neptune.py::TestNeptuneLogger::test_after_save_checkpoint - FileNotFoundError: [Errno 2] No such file or directory: 'path/to/models/last'
FAILED loggers/test_neptune.py::TestNeptuneLogger::test_neptune_leave_open_experiment_after_fit - AttributeError: 'NoneType' object has no attribute 'from_stream'
FAILED loggers/test_neptune.py::TestNeptuneLogger::test_neptune_log_metrics_on_trained_model - AttributeError: 'NoneType' object has no attribute 'from_stream' |
@carmocca I think I fixed the tests (they pass locally at least), but the pre-commit failure I see now doesn't seem to have anything to do with my changes and they only appeared after I merged the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @Blaizzy for a final stamp from Neptune
(cherry picked from commit ef9df05)
(cherry picked from commit ef9df05)
(cherry picked from commit ef9df05)
What does this PR do?
Fixes (issue on neptune-client repo):
neptune-ai/neptune-client#884
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist