-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App: Fix AppState, streamlit example #17452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
requested review from
tchaton,
lantiga,
awaelchli,
Borda and
carmocca
as code owners
April 24, 2023 10:15
github-actions
bot
added
app (removed)
Generic label for Lightning App package
ci
Continuous Integration
labels
Apr 24, 2023
Borda
approved these changes
Apr 24, 2023
tchaton
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Borda
pushed a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit e826724)
Borda
pushed a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit e826724)
lantiga
pushed a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit e826724)
Borda
pushed a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit e826724)
lantiga
pushed a commit
that referenced
this pull request
Apr 26, 2023
(cherry picked from commit e826724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
ci
Continuous Integration
priority: 1
Medium priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Go straight to the flow IP address for the app state
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca @tchaton