Support compiling a module after it was set up by Fabric #17529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… fabric/compile-after-setup
for more information, see https://pre-commit.ci
carmocca
approved these changes
May 3, 2023
carmocca
reviewed
May 3, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda
approved these changes
May 3, 2023
Borda
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit a533f68)
Borda
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit a533f68)
lantiga
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit a533f68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fabric supports working with models output by
torch.compilebecause thetorch._dynamo.OptimizedModulewrapper is a subtype ofnn.Module. So to Fabric, a compiled module will look just like any othernn.Module. This works fine:However, it is also possible for the user to compile their model after they called
fabric.setup()like so:This also works without issues in most cases, but some fabric methods expect a _FabricModule or have instance checks against it (e.g., fabric.save, fabric.load, fabric.no_backward_sync). These would fail because what we are passing in is a OptimizedModule. This PR makes sure we unwrap the optimized module in the methods that require the original unwrapped module.
Part of #16971
cc @Borda @carmocca @justusschock @awaelchli