-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): store source app #17892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Jun 21, 2023
yurijmikhalevich
force-pushed
the
feat/plugin-update
branch
from
June 22, 2023 09:59
3a5af20
to
12f3b38
Compare
yurijmikhalevich
changed the title
feat: store plugin name
feat(plugin): store source app
Jun 22, 2023
for more information, see https://pre-commit.ci
yurijmikhalevich
requested review from
tchaton,
lantiga,
awaelchli,
ethanwharris and
Borda
as code owners
June 22, 2023 11:03
Borda
approved these changes
Jun 22, 2023
nohalon
approved these changes
Jun 22, 2023
tchaton
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Borda
force-pushed
the
feat/plugin-update
branch
from
June 22, 2023 13:19
28a2456
to
27d3d3b
Compare
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 60f2e3a)
lantiga
pushed a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit 60f2e3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR makes plugin server accept and store pluginId.
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda