-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show CUDA matmul precision info only ever once #17960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
pl
Generic label for PyTorch Lightning package
accelerator: cuda
Compute Unified Device Architecture GPU
labels
Jul 1, 2023
carmocca
approved these changes
Jul 1, 2023
justusschock
approved these changes
Jul 3, 2023
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jul 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #17960 +/- ##
=========================================
- Coverage 84% 61% -23%
=========================================
Files 425 420 -5
Lines 32053 31964 -89
=========================================
- Hits 26816 19502 -7314
- Misses 5237 12462 +7225 |
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit c5fae64)
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit c5fae64)
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit c5fae64)
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit c5fae64)
lantiga
pushed a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit c5fae64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: cuda
Compute Unified Device Architecture GPU
bug
Something isn't working
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, whenever you call
Fabric.setup()
orTrainer.fit()
, the info messageis printed. Since this is a global setting for the entire script, I propose to only show the info once ever during the lifetime of the program. This avoids spamming the info message across the output.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca @justusschock @awaelchli