New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add launch commands #18155

Merged

lantiga merged 21 commits into master from launcher

Jul 28, 2023

Collaborator

lantiga commented Jul 25, 2023 •

edited by github-actions bot

Loading

What does this PR do?

Adds launch commands to the main package.

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca

lantiga requested review from tchaton, awaelchli and ethanwharris as code owners

July 25, 2023 07:55

lantiga self-assigned this

github-actions bot added the app (removed) label

Contributor

github-actions bot commented Jul 25, 2023 •

edited

Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 fabric: Docs

Check ID	Status
make-doctest (fabric)	success	✅
make-html (fabric)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_data: CPU workflow

Check ID	Status
data-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
data-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
data-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅

These checks are required after the changes to tests/tests_data/datasets/test_env.py, pyproject.toml.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅

These checks are required after the changes to pyproject.toml.

🔴 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	failure	❌

These checks are required after the changes to pyproject.toml.

🔴 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	failure	❌
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_launch.py, src/lightning/app/launcher/__init__.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/utilities/packaging/lightning_utils.py, tests/tests_app/cli/launch_data/app_v0/__init__.py, tests/tests_app/cli/launch_data/app_v0/app.py, tests/tests_app/cli/launch_data/app_v0/ui/a/index.html, tests/tests_app/cli/launch_data/app_v0/ui/b/index.html, tests/tests_app/cli/test_cmd_launch.py, tests/tests_app/launcher/test_lightning_backend.py, tests/tests_app/launcher/test_lightning_hydrid.py, tests/tests_app/launcher/test_running_flow.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/test_imports.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_launch.py, src/lightning/app/launcher/__init__.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/utilities/packaging/lightning_utils.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_launch.py, src/lightning/app/launcher/__init__.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/utilities/packaging/lightning_utils.py, pyproject.toml.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_launch.py, src/lightning/app/launcher/__init__.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/utilities/packaging/lightning_utils.py, pyproject.toml.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_launch.py, src/lightning/app/launcher/__init__.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/utilities/packaging/lightning_utils.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

tchaton approved these changes

View reviewed changes

Contributor

tchaton left a comment

LGTM ! Finally :)

lantiga marked this pull request as draft

July 25, 2023 07:58

Collaborator Author

lantiga commented Jul 25, 2023

In draft until we verify e2e

lantiga force-pushed the launcher branch from a9b51a6 to bce5c4f Compare

July 25, 2023 14:24

Borda reviewed

View reviewed changes

src/lightning/app/launcher/launcher.py Outdated Show resolved Hide resolved

Borda reviewed

View reviewed changes

src/lightning/app/launcher/launcher.py Outdated Show resolved Hide resolved

src/lightning/app/launcher/launcher.py Outdated Show resolved Hide resolved

src/lightning/app/launcher/launcher.py Outdated Show resolved Hide resolved

src/lightning/app/launcher/lightning_backend.py Outdated Show resolved Hide resolved

src/lightning/app/launcher/lightning_hybrid_backend.py Outdated Show resolved Hide resolved

tests/tests_app/cli/test_cmd_launch.py Outdated Show resolved Hide resolved

lantiga force-pushed the launcher branch from 8db05c5 to dfdeeaa Compare

July 26, 2023 08:31

lantiga marked this pull request as ready for review

July 26, 2023 08:51

lantiga requested a review from carmocca as a code owner

July 26, 2023 09:34

github-actions bot added the ci label

awaelchli approved these changes

View reviewed changes

mergify bot added the ready label

awaelchli added the feature label

mergify bot added has conflicts and removed ready labels

github-actions bot removed the ci label

mergify bot added ready and removed has conflicts ready labels

lantiga added 4 commits

July 28, 2023 11:42


          Add launcher to main repo

55d794c


          Move launcher CLI to main CLI

7e16775


          Launch CLI tests

24621db


          Fix tests

fff9d6c

lantiga and others added 16 commits

July 28, 2023 11:43


          Remove tabulate dependency

f23108e


          Allow access through lightning_app package

a50de6a


          Avoid conditional import in CLI

b021161


          Apply suggestions from code review

090165a


          [pre-commit.ci] auto fixes from pre-commit.com hooks

655ea3d

for more information, see https://pre-commit.ci


          Remove conditional input

e14484f


          Skip mypy checks for launcher

1fa44f4


          Add return type annotation

24ea0e0


          Fix duplicated app_metadata.py

9a34fb2


          Add missing import

762bfac


          Fix test

9665c98


          Add skip test import depth

bd539ce


          Remove leftover conditional import


          Change expected output to reflect the new tabulate method


          Remove check on deprecated functionality

0a47dc9


          Improve stability of test

1d1f2bc

lantiga force-pushed the launcher branch from fd835ed to 1d1f2bc Compare

July 28, 2023 09:44


          Skip unrelated failing test on Windows

db8fa97

lantiga requested review from nohalon and justusschock as code owners

July 28, 2023 16:00

lantiga merged commit c740a63 into master

lantiga deleted the launcher branch

July 28, 2023 16:03

awaelchli mentioned this pull request

Weekly minor patch release 2.0.7 [rebase & merge] #18270

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Borda Borda left review comments

tchaton tchaton approved these changes

awaelchli awaelchli approved these changes

ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

carmocca Awaiting requested review from carmocca

nohalon Awaiting requested review from nohalon

justusschock Awaiting requested review from justusschock justusschock is a code owner

Labels

app (removed) feature ready