Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide for renamed progress bar base class #18178

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 27, 2023

What does this PR do?

Fixes #18146

cc @Borda

@awaelchli awaelchli added docs Documentation related pl Generic label for PyTorch Lightning package labels Jul 27, 2023
@awaelchli awaelchli added this to the 2.1 milestone Jul 27, 2023
@awaelchli awaelchli marked this pull request as ready for review July 28, 2023 00:02
@github-actions
Copy link
Contributor

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to docs/source-pytorch/upgrade/sections/1_9_devel.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Jul 31, 2023
@awaelchli awaelchli merged commit 1e0fa18 into master Jul 31, 2023
@awaelchli awaelchli deleted the docs/progress-bar-migration branch July 31, 2023 13:36
Borda pushed a commit that referenced this pull request Aug 14, 2023
lexierule pushed a commit that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'ProgressBarBase' from 'pytorch_lightning.callbacks.progress'
3 participants