New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze version for jsonargparse <4.23.0 #18182

Merged

awaelchli merged 1 commit into master from ci/jsonargparse-strict

Jul 28, 2023

Contributor

awaelchli commented Jul 27, 2023 •

edited by github-actions bot

Loading

What does this PR do?

Fixes #18180 (an attempt)

cc @carmocca @Borda


          strict

02a3885

awaelchli requested review from lantiga, Borda and tchaton as code owners

July 27, 2023 22:59

awaelchli added the ci label

github-actions bot added pl and removed ci labels

awaelchli added ci 3rd party and removed pl labels

awaelchli added this to the 2.0.x milestone

Contributor

github-actions bot commented Jul 27, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/pytorch/extra.txt.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to requirements/pytorch/extra.txt.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/pytorch/extra.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to requirements/pytorch/extra.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.12, 11.7.1)	success	✅
build-cuda (3.9, 1.13, 11.8.0)	success	✅
build-cuda (3.9, 1.13, 12.0.1)	success	✅
build-cuda (3.10, 2.0, 11.8.0)	success	✅
build-cuda (3.10, 2.0, 12.0.1)	success	✅
build-pl (3.9, 1.12, 11.7.1)	success	✅
build-pl (3.9, 1.13, 11.8.0)	success	✅
build-pl (3.9, 1.13, 12.0.1)	success	✅
build-pl (3.10, 2.0, 11.8.0)	success	✅
build-pl (3.10, 2.0, 12.0.1)	success	✅

These checks are required after the changes to requirements/pytorch/extra.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/pytorch/extra.txt.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to requirements/pytorch/extra.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

carmocca approved these changes

View reviewed changes

Borda approved these changes

View reviewed changes

mergify bot added the ready label

Borda changed the title ~~CI: Strict version check for jsonargparse~~ Freeze version for jsonargparse <4.23.0

Member

Borda commented Jul 28, 2023

Note this is not for CI but all users =)

awaelchli merged commit b25b3f6 into master

awaelchli deleted the ci/jsonargparse-strict branch

July 28, 2023 08:35

Borda pushed a commit that referenced this pull request


          Freeze version for jsonargparse <4.23.0 (#18182)

2e828e2

(cherry picked from commit b25b3f6)

lexierule pushed a commit that referenced this pull request


          Freeze version for jsonargparse <4.23.0 (#18182)

6400f89

(cherry picked from commit b25b3f6)

carmocca mentioned this pull request

Relax constraints on jsonargparse dependency #18632

Merged

10 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carmocca carmocca approved these changes

Borda Borda approved these changes

lantiga Awaiting requested review from lantiga lantiga is a code owner

tchaton Awaiting requested review from tchaton tchaton is a code owner

Labels

3rd party ci ready