Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rm links checks from required #18340

Merged
merged 3 commits into from
Aug 21, 2023
Merged

ci: rm links checks from required #18340

merged 3 commits into from
Aug 21, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 18, 2023

What does this PR do?

seems that the Python download badge is quite sensitive, and as we do not have link in docs as required, not sure why keep readme links as required...

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca

@Borda Borda added docs Documentation related ci Continuous Integration labels Aug 18, 2023
@github-actions
Copy link
Contributor

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda mentioned this pull request Aug 18, 2023
7 tasks
@mergify mergify bot added the ready PRs ready to be merged label Aug 21, 2023
@Borda Borda closed this in #18345 Aug 21, 2023
@Borda Borda reopened this Aug 21, 2023
@Borda Borda merged commit 300e6cf into master Aug 21, 2023
11 checks passed
@Borda Borda deleted the ci/links branch August 21, 2023 17:07
Borda added a commit that referenced this pull request Aug 28, 2023
@awaelchli awaelchli added this to the 2.0.x milestone Aug 29, 2023
lantiga pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants