Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade guide regarding removed Trainer.reset_*_dataloaders() #18341

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 18, 2023

What does this PR do?

Minor fix for the migration guide.

cc @Borda

@awaelchli awaelchli added this to the 2.1 milestone Aug 18, 2023
@awaelchli awaelchli added the docs Documentation related label Aug 18, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
docs-checks (pytorch, doctest) success
make-html (pytorch) success

These checks are required after the changes to docs/source-pytorch/upgrade/sections/1_8_regular.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda merged commit 2ca1571 into master Aug 18, 2023
@Borda Borda deleted the docs/fix-setup-data-migration branch August 18, 2023 16:24
@mergify mergify bot added the ready PRs ready to be merged label Aug 18, 2023
Borda pushed a commit that referenced this pull request Aug 28, 2023
lantiga pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants