-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make delimiter in rich progress bar configurable #18372
Make delimiter in rich progress bar configurable #18372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you also add a changelog entry? (in src/lightning/pytorch/CHANGELOG.md)
Should I make a new PR for this? |
No worries, this isn't a critical thing. We will include the update in one of the next PRs. Thanks a lot for your contributions. |
Okay, perfect! Thank you for helping me and giving me the opportunity to contribute. |
What does this PR do?
Fixes #18366
Enables configurable delimiter in the metrics display column of the rich progress bar
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist