Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make delimiter in rich progress bar configurable #18372

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Make delimiter in rich progress bar configurable #18372

merged 8 commits into from
Aug 24, 2023

Conversation

quintenroets
Copy link
Contributor

@quintenroets quintenroets commented Aug 23, 2023

What does this PR do?

Fixes #18366

Enables configurable delimiter in the metrics display column of the rich progress bar

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 23, 2023
@quintenroets quintenroets changed the title Feature 18367 configurable progress delimiter Feature 18366 configurable progress delimiter Aug 23, 2023
@awaelchli awaelchli changed the title Feature 18366 configurable progress delimiter Make delimiter in rich progress bar configurable Aug 23, 2023
@awaelchli awaelchli added feature Is an improvement or enhancement community This PR is from the community progress bar: rich labels Aug 23, 2023
@mergify mergify bot removed the has conflicts label Aug 23, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you also add a changelog entry? (in src/lightning/pytorch/CHANGELOG.md)

@mergify mergify bot added the ready PRs ready to be merged label Aug 24, 2023
@awaelchli awaelchli added this to the 2.1 milestone Aug 24, 2023
@Borda Borda merged commit 8680dc5 into Lightning-AI:master Aug 24, 2023
@quintenroets
Copy link
Contributor Author

LGTM. Could you also add a changelog entry? (in src/lightning/pytorch/CHANGELOG.md)

Should I make a new PR for this?

@awaelchli
Copy link
Contributor

No worries, this isn't a critical thing. We will include the update in one of the next PRs.

Thanks a lot for your contributions.

@quintenroets
Copy link
Contributor Author

No worries, this isn't a critical thing. We will include the update in one of the next PRs.

Thanks a lot for your contributions.

Okay, perfect! Thank you for helping me and giving me the opportunity to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package progress bar: rich ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inefficiency in Rich Progress bar
4 participants