Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix & fuse docker builds #18440

Merged
merged 4 commits into from
Aug 30, 2023
Merged

ci: fix & fuse docker builds #18440

merged 4 commits into from
Aug 30, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 30, 2023

What does this PR do?

Addressing following failures:

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @Borda @tchaton

@github-actions github-actions bot added the ci Continuous Integration label Aug 30, 2023
@Borda Borda added the release label Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.12, 11.7.1) success
build-cuda (3.9, 1.13, 11.8.0) success
build-cuda (3.9, 1.13, 12.0.1) success
build-cuda (3.10, 2.0, 11.8.0) success
build-cuda (3.10, 2.0, 12.0.1) success
build-pl (3.9, 1.12, 11.7.1) success
build-pl (3.9, 1.13, 11.8.0) success
build-pl (3.9, 1.13, 12.0.1) success
build-pl (3.10, 2.0, 11.8.0) success
build-pl (3.10, 2.0, 12.0.1) success

These checks are required after the changes to .github/workflows/docker-build.yml.

🟢 lightning_app: Docs
Check ID Status
docs-make (app, doctest) success
docs-make (app, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda added the priority: 1 Medium priority task label Aug 30, 2023
@Borda Borda added this to the 2.0.x milestone Aug 30, 2023
@Borda Borda requested a review from lantiga August 30, 2023 16:28
@Borda Borda merged commit 3a70714 into master Aug 30, 2023
@Borda Borda deleted the ci/dockers branch August 30, 2023 17:11
@mergify mergify bot added the ready PRs ready to be merged label Aug 30, 2023
@Borda Borda mentioned this pull request Aug 31, 2023
7 tasks
Borda added a commit that referenced this pull request Sep 12, 2023
(cherry picked from commit 3a70714)
lantiga pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants